fix: move lighting tools to their own module to avoid circular import #89

ianohara · 2025-02-03T17:48:10Z

When running tests, we'd get this:

tests/control/test_microscope.py:1: in <module>
    import control.microscope
control/microscope.py:7: in <module>
    import control.core.core as core
control/core/core.py:28: in <module>
    import control.serial_peripherals as serial_peripherals
control/serial_peripherals.py:6: in <module>
    from control.microscope import LightSourceType, IntensityControlMode, ShutterControlMode
E   ImportError: cannot import name 'LightSourceType' from partially initialized module 'control.microscope' (most likely due to a circular import) (/home/ian/projects/cephla/squid/software/control/microscope.py)

To fix this, move all the IlluminationController machinery to its own module.

Tested by: Unit tests run and pass now, and a local gui sim starts.

ianohara added 8 commits February 3, 2025 17:14

fix: move lighting tools to their own module to avoid circular import

f2ce126

try recover space for github runner

bca3506

print disk space

f8c74ce

Add action that frees up a bunch of memory

32b8319

try to fix setup script to allow specifying existing repo

975fd3e

Expand the path

d76a122

use workspace var

852a4cf

Fix working directories

1b0173a

ianohara force-pushed the ian/fix-lighting-circular-imports branch from 230a0dd to 1b0173a Compare February 4, 2025 01:15

ianohara merged commit 6c35cd4 into master Feb 4, 2025
1 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: move lighting tools to their own module to avoid circular import #89

fix: move lighting tools to their own module to avoid circular import #89

ianohara commented Feb 3, 2025

fix: move lighting tools to their own module to avoid circular import #89

fix: move lighting tools to their own module to avoid circular import #89

Conversation

ianohara commented Feb 3, 2025